Skip to content

🎨 Batch api-server->wb-api-server requests in map endpoint in the api-server #8514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 67 commits into
base: master
Choose a base branch
from
Open

🎨 Batch api-server->wb-api-server requests in map endpoint in the api-server #8514

wants to merge 67 commits into from

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Oct 14, 2025 •
edited
Loading

What do these changes do?

Motivated by https://git.speag.com/oSparc/osparc-infra/-/issues/incident/81, this PR batches rpc requests api-server -> wb-api-server to minimize the number of internal requests required to handle the map endpoint in the api-server.

  • With these changes the number of requests api-server->wb-api-server performed when calling the map endpoint does not depend on the number of inputs passed.
  • Previously the map endpoint in the api-server essentially had a loop around the run endpoint which meant that the number of RPC requests api-server->wb-api-server performed when a user called the map endpoint was #inputs*#(requests in run endpoint). With these changes and 🐛 Ensure function execute permission check is performed only once in map endpoint #8499 the number of requests will be #(requests in run endpoint).
image

Related issue/s

How to test

  • This only modifies already existing endpoints in the webserver. Tests have been modified and enhanced accoordingly.

Dev-ops

@codecov
Copy link

codecov bot commented Oct 14, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 86.53846% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.27%. Comparing base (d6b73db) to head (5fcf1be).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8514      +/-   ##
==========================================
+ Coverage   87.23%   87.27%   +0.03%     
==========================================
  Files        1934     1671     -263     
  Lines       76057    68804    -7253     
  Branches     1349     1010     -339     
==========================================
- Hits        66350    60048    -6302     
+ Misses       9303     8442     -861     
+ Partials      404      314      -90
Flag Coverage Δ
integrationtests 63.86% <18.57%> (-0.12%) ⬇️
unittests 85.81% <86.53%> (-0.09%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 92.90% <100.00%> (+0.02%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.17% <ø> (ø)
pkg_service_library 70.96% <0.00%> (+0.01%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 84.89% <ø> (-0.06%) ⬇️
agent 93.10% <ø> (ø)
api_server ∅ <ø> (∅)
autoscaling 95.00% <ø> (ø)
catalog 92.06% <ø> (ø)
clusters_keeper 99.14% <ø> (ø)
dask_sidecar 92.38% <ø> (ø)
datcore_adapter 97.95% <ø> (ø)
director 75.72% <ø> (ø)
director_v2 90.90% <ø> (-0.13%) ⬇️
dynamic_scheduler 96.66% <ø> (∅)
dynamic_sidecar 90.44% <ø> (ø)
efs_guardian 89.83% <ø> (ø)
invitations 90.90% <ø> (ø)
payments 92.80% <ø> (ø)
resource_usage_tracker 92.22% <ø> (-0.06%) ⬇️
storage 86.84% <ø> (-0.09%) ⬇️
webclient ∅ <ø> (∅)
webserver 87.05% <88.57%> (-0.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b73db...5fcf1be. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 5fcf1be.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests Broken 0 View View

@odeimaiz odeimaiz added this to the Imparable milestone Oct 15, 2025
@bisgaard-itis
batch cache endpoint
988004b
@bisgaard-itis
improve sql query
9924f3d
@bisgaard-itis
start using cache
db49588
@bisgaard-itis
implement cache in api-server
4a954f6
@bisgaard-itis
first attempt at batching function job creation
d3b9353
@bisgaard-itis
fix tests using register rpc endpoint
f5bec46
@bisgaard-itis
propagate usage of preregistration function to api-server
366c4b6
@bisgaard-itis
first attempt at implementing batch patch function job method
2c8f63b
@bisgaard-itis
update models
308f853
@bisgaard-itis
ensure meaningful error message is raised
cb9d138
@bisgaard-itis
small fix
91eda8d
@bisgaard-itis
add exception in case of unrecoverable error
d11dd51
@bisgaard-itis
improve comments
e959e4d
@bisgaard-itis
improve patch in repository
4f1b9b4
@bisgaard-itis
implement patch function job endpoint
7f11bab
@bisgaard-itis
fixes
f2c3fb6
@bisgaard-itis
minor cleanup
4a3a3bb
@bisgaard-itis
use new patch method in run_function
4f2918d
@bisgaard-itis
propagate task creation all the way out
fa34d1c
@bisgaard-itis
update openapi specs
b0cc3fa
@bisgaard-itis
small change
661bd3a
@bisgaard-itis
start fixing tests
7804a04
@bisgaard-itis
fix more tests
f4bae45
@bisgaard-itis
fix yet another test
20088b0
@bisgaard-itis
fix tests
76a6f6e
@bisgaard-itis
cleanup
8f5945c
pcrespov
pcrespov approved these changes Oct 17, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx.. Following our offline discussion, check the batch operations and see if you can reuse and even extend some of these concepts
tjhx

@bisgaard-itis
use batch models/schemas in register function job rpc endpoints
38026e3
@bisgaard-itis
fix tests
7b38b4d
@bisgaard-itis
start using batch register function jobs in api-server
94a7052
@bisgaard-itis
clean up
809964b
@bisgaard-itis
improve patch model schema
7a68768
@bisgaard-itis
refactor patch method
97993f2
@bisgaard-itis
use patch batch endpoint
0ebd500
@bisgaard-itis
start fixing find_cache method
650986d
@bisgaard-itis
batch cache endpoints
c3f2755
@bisgaard-itis
change requirement for bach get
1e7486a
@bisgaard-itis
name change
d5786aa
@bisgaard-itis
use custom signature for batch cache endpoint
77b4a5f
@bisgaard-itis
fix tests
d0f3142
@bisgaard-itis
Merge branch 'master' into 8506-batch-db-requests-in-map-endpoint
9f39f70
@bisgaard-itis
remove fcn
e6f289d
@bisgaard-itis
fix api-server tests
5d99508
@bisgaard-itis
pylint
74052c5
@bisgaard-itis
remove min list length constraint and update openapi specs
ad85bd9
@bisgaard-itis
rename lambda
43059b8
@bisgaard-itis
remove double FunctionJobCreationTaskStatus import
3dce8b1
@bisgaard-itis
don't update status when patching job
ade3efe
@bisgaard-itis
status_filter -> cached_job_statuses
ee7bb37
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@wvangeit wvangeit Awaiting requested review from wvangeit wvangeit is a code owner

Assignees

@bisgaard-itis bisgaard-itis

Labels

a:apiserver api-server service Meta-modeling

Projects

None yet

Milestone

Imparable

Development

Successfully merging this pull request may close these issues.

8 participants

@bisgaard-itis @giancarloromeo @wvangeit @GitHK @pcrespov @sanderegg @matusdrobuliak66 @odeimaiz